rmatharu commented on a change in pull request #1585:
URL: https://github.com/apache/samza/pull/1585#discussion_r814161456
##########
File path: samza-core/src/main/java/org/apache/samza/container/RunLoop.java
##########
@@ -276,6 +276,9 @@ private void runTasks(IncomingMessageEnvelope envelope) {
consumerMultiplexer.tryUpdate(envelope.getSystemStreamPartition(elasticityFactor));
log.trace("updating the system consumers for ssp keyBucket {} not
processed by this runloop",
envelope.getSystemStreamPartition(elasticityFactor));
+ // since this envelope is not processed by the container, need to
decrement the # envelopes metric
+ // # envelopes metric was incremented when the envelope was returned
by the SystemConsumers
+ containerMetrics.envelopes().dec();
Review comment:
Can we add a metric here called envelopesSkipped that we increment in
this case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
