lakshmi-manasa-g commented on a change in pull request #1585:
URL: https://github.com/apache/samza/pull/1585#discussion_r819996936
##########
File path:
samza-core/src/main/scala/org/apache/samza/system/SystemConsumers.scala
##########
@@ -219,6 +231,7 @@ class SystemConsumers (
// If elasticity is enabled then the RunLoop gives SSP with keybucket
// but the MessageChooser does not know about the KeyBucket
// hence, use an SSP without KeyBucket
+ sspKeyBucketsRegistered.add(ssp)
Review comment:
`sspKeyBucketsRegistered` is used in one place only - where the
choseObject is incremented. is the comment to not have
`sspKeyBucketsRegistered` if elasticity factor = 1? With elasticity factor > 1,
this book keeping is needed for correct counting of chose-object
removeKeyBucket is needed when elasticity > 1. it is currently used in 4
places and without this it would mean an if then else check in all the places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
