mynameborat commented on PR #1594:
URL: https://github.com/apache/samza/pull/1594#issuecomment-1089201920
I am not quite clear about this change. `job.coordinator.factory` cannot be
an empty string because it impacts coordinator utils code path.
```public String getJobCoordinationUtilsFactoryClassName() {
String coordinatorFactory = get(JOB_COORDINATOR_FACTORY,
DEFAULT_COORDINATOR_FACTORY);
String coordinationUtilsFactory;
if (AZURE_COORDINATOR_FACTORY.equals(coordinatorFactory)) {
coordinationUtilsFactory = AZURE_COORDINATION_UTILS_FACTORY;
} else if
(PassthroughJobCoordinatorFactory.class.getName().equals(coordinatorFactory)) {
coordinationUtilsFactory =
PassthroughCoordinationUtilsFactory.class.getName();
} else if
(ZkJobCoordinatorFactory.class.getName().equals(coordinatorFactory)) {
coordinationUtilsFactory = ZkCoordinationUtilsFactory.class.getName();
} else {
throw new SamzaException(String.format("Coordination factory: %s
defined by the config: %s is invalid.", coordinatorFactory,
JOB_COORDINATOR_FACTORY));
}```
Additionally, If `ClusterBasedJobCoordinator` is used when the class name is
empty, shouldn't `getJobCoordinatorFactoryClassName()` ideally return
`ClusterBasedJobCoordinator`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
