mynameborat commented on PR #1594: URL: https://github.com/apache/samza/pull/1594#issuecomment-1089519493
> The flow you mentioned above is only on the standalone path, and it isn't affected by this PR. Do you think I should also change `getJobCoordinationUtilsFactoryClassName` to check for `job.coordinator.factory` being the empty string? > > This PR just covers `getOptionalJobCoordinatorFactoryClassName`, which is only used in `JobCoordinatorLaunchUtil` (which is only used by YARN). The challenge with having `getJobCoordinatorFactoryClassName` return `ClusterBasedJobCoordinator` is that we need to be returning a factory for the `ClusterBasedJobCoordinator` and `ClusterBasedJobCoordinator` doesn't implement `JobCoordinator`. Using null or empty string for `job.coordinator.factory` allows us to fall back to the previous flow for YARN. Thanks for clarifying. You can leave it as is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
