jia-gao commented on code in PR #1627:
URL: https://github.com/apache/samza/pull/1627#discussion_r974445013
##########
samza-log4j2/src/main/java/org/apache/samza/logging/log4j2/StreamAppender.java:
##########
@@ -73,7 +73,7 @@ public class StreamAppender extends AbstractAppender {
private final BlockingQueue<EncodedLogEvent> logQueue = new
LinkedBlockingQueue<>(DEFAULT_QUEUE_SIZE);
private SystemStream systemStream = null;
- private SystemProducer systemProducer = null;
+ protected SystemProducer systemProducer = null;
Review Comment:
we want to mock a SystemProducerException to mock the case that a kafka
exception thrown by SystemProducer in InLogsAppender. And InLogsAppender is not
in the same package, we need to set systemProducer for InLogsAppender
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
