[GitHub] [samza] mynameborat commented on a diff in pull request #1627: Make StreamAppender extensible for sending event to SystemProducer

Mon, 19 Sep 2022 09:57:39 -0700 


mynameborat commented on code in PR #1627:
URL: https://github.com/apache/samza/pull/1627#discussion_r974477277


##########
samza-log4j2/src/main/java/org/apache/samza/logging/log4j2/StreamAppender.java:
##########
@@ -73,7 +73,7 @@ public class StreamAppender extends AbstractAppender {
   private final BlockingQueue<EncodedLogEvent> logQueue = new 
LinkedBlockingQueue<>(DEFAULT_QUEUE_SIZE);
 
   private SystemStream systemStream = null;
-  private SystemProducer systemProducer = null;
+  protected SystemProducer systemProducer = null;

Review Comment:
   It seems like this needs to be revisited on why this isn't mock friendly for 
unit tests outside the package.
   Let us get this for now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@samza.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to