ryucc commented on code in PR #1651:
URL: https://github.com/apache/samza/pull/1651#discussion_r1087130547
##########
samza-core/src/main/java/org/apache/samza/zk/ZkLeaderElector.java:
##########
@@ -69,6 +71,7 @@ public ZkLeaderElector(String processorIdStr, ZkUtils
zkUtils) {
@VisibleForTesting
public ZkLeaderElector(String processorIdStr,
ZkUtils zkUtils,
+ @Nonnull
IZkDataListener previousProcessorChangeListener) {
this.processorIdStr = processorIdStr;
Review Comment:
https://developer.android.com/reference/androidx/annotation/VisibleForTesting
Confirm this should be safe. This annotation would make the method `private`
by default, so it is only used by our tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
