ryucc commented on code in PR #1651:
URL: https://github.com/apache/samza/pull/1651#discussion_r1088226536
##########
samza-core/src/main/java/org/apache/samza/zk/ZkLeaderElector.java:
##########
@@ -69,6 +71,7 @@ public ZkLeaderElector(String processorIdStr, ZkUtils
zkUtils) {
@VisibleForTesting
public ZkLeaderElector(String processorIdStr,
ZkUtils zkUtils,
+ @Nonnull
IZkDataListener previousProcessorChangeListener) {
this.processorIdStr = processorIdStr;
Review Comment:
@mynameborat
The path forward isn't clear to me.
1. We want to remove the `@NonNull` line
2. Do we want to remove this constructor?
3. Need to choose one of the following:
a. Pass in a non-null ZkDataListener in the tests, or
b. Use the constructor without the last argument.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
