saniyanajeeb commented on code in PR #1700: URL: https://github.com/apache/samza/pull/1700#discussion_r1636108521
########## samza-azure/src/main/java/org/apache/samza/system/azureblob/BlobClientBuilderFactory.java: ########## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.samza.system.azureblob; + +/** + * Constructs a new instance of {@link AzureBlobClientBuilder} + * from factory provided by configuration. + */ +public interface BlobClientBuilderFactory { + /** + * Create a new instance of {@link AzureBlobClientBuilder} + * @param systemName Name of the system Review Comment: Can you make the parameter description more intuitive to clarify their purpose and expected values. Something like: @param systemName The name of the system for which the blob client builder is being created. @param azureUrlFormat The format of the Azure URL, which should conform to Azure's URL formatting requirements. @param azureBlobConfig The configuration settings for Azure Blob, encapsulated in an {@link AzureBlobConfig} object. This includes details like account name, account key, and other relevant settings. ########## samza-azure/src/main/java/org/apache/samza/system/azureblob/BlobClientBuilder.java: ########## @@ -0,0 +1,15 @@ +package org.apache.samza.system.azureblob; + +import com.azure.storage.blob.BlobServiceAsyncClient; + + +/** + * Create a BlobServiceAsyncClient. Implementation controls construction of + * underlying client. + */ +public interface BlobClientBuilder { + /** + * create a client for ABS (uploads) Review Comment: nit: Create a client for uploading to Azure Blob Store. ########## samza-azure/src/main/java/org/apache/samza/system/azureblob/BlobClientBuilder.java: ########## @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.samza.system.azureblob; + +import com.azure.storage.blob.BlobServiceAsyncClient; + + +/** + * Create a BlobServiceAsyncClient. Implementation controls construction of + * underlying client. + */ +public interface BlobClientBuilder { + /** + * create a client for ABS (uploads) + */ + BlobServiceAsyncClient getBlobServiceAsyncClient(); Review Comment: Also add @return to the java doc: @return A new instance of {@link BlobServiceAsyncClient}. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
