lakshmi-manasa-g commented on code in PR #1700: URL: https://github.com/apache/samza/pull/1700#discussion_r1715580396
########## samza-azure/src/main/java/org/apache/samza/system/azureblob/BlobClientBuilder.java: ########## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.samza.system.azureblob; + +import com.azure.storage.blob.BlobServiceAsyncClient; + + +/** + * Create a BlobServiceAsyncClient. Implementation controls construction of Review Comment: from the current PR changes perspective, its only code refactoring. but from the interface pov, there is a new interface that samza users can implement and need some guidelines on thread safety of the new impl they will add to their usage. for this particular interface, it looks like this --> system producer is a single instance per samza container and hence there will be a single instance of this client that will be instantiated per container and all the tasks (+ threads) within the container will use the same instance of the client. Hence the client impl NEEDS to be thread safe. for the purpose of this PR, there is no code change needed since its only a refactor and uses the pre-existing impl of the client. so please add the above thread safety requirements along with info on how the client is closed in the system producer and if a new impl of this interface needs to do something special abt closing the client -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
