ajothomas commented on code in PR #1706:
URL: https://github.com/apache/samza/pull/1706#discussion_r1725455573
##########
samza-core/src/main/java/org/apache/samza/config/StorageConfig.java:
##########
@@ -263,6 +265,14 @@ public long getChangelogMinCompactionLagMs(String
storeName) {
return getLong(minCompactLagConfigName,
getDefaultChangelogMinCompactionLagMs());
}
+ /**
+ * Helper method to get the default RocksDB max manifest file size in bytes,
which is default to 1GB.
+ */
+ public long getDefaultMaxManifestFileSizeBytes() {
+ String defaultMaxManifestFileSizeConfigName =
String.format(ROCKSDB_MAX_MANIFEST_FILE_SIZE, "default");
Review Comment:
Instead of using string "default", use a constant. In the docs, describe the
purpose of using `default`. It might not be clear to the reader that
`stores.default` is a samza config which applies to all stores.
Please add details the the method docs regarding default store config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
