dxichen commented on code in PR #1706:
URL: https://github.com/apache/samza/pull/1706#discussion_r1727979203
##########
samza-kv-rocksdb/src/main/java/org/apache/samza/storage/kv/RocksDbKeyValueReader.java:
##########
@@ -61,7 +61,12 @@ public RocksDbKeyValueReader(String storeName, String
dbPath, Config config) {
valueSerde =
getSerdeFromName(storageConfig.getStorageMsgSerde(storeName).orElse(null),
serializerConfig);
// get db options
- Options options = RocksDbOptionsHelper.options(config, 1, new
File(dbPath), StorageEngineFactory.StoreMode.ReadWrite);
+ Options options = RocksDbOptionsHelper.options(config,
+ 1,
+ StorageConfig.DEFAULT_ROCKSDB_MAX_MANIFEST_FILE_SIZE_IN_BYTES,
Review Comment:
`StorageConfig.getDefaultMaxManifestFileSizeBytes`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
