BenJFan commented on a change in pull request #1523:
URL:
https://github.com/apache/incubator-seatunnel/pull/1523#discussion_r831877512
##########
File path:
seatunnel-core/seatunnel-core-base/src/main/java/org/apache/seatunnel/config/ConfigBuilder.java
##########
@@ -157,6 +158,7 @@ private boolean checkIsContainHive() {
String serviceClassName = serviceClass.getName();
String clsNameToLower = serviceClassName.toLowerCase();
if (clsNameToLower.equals(canonicalName.toLowerCase())) {
+ plugin.setConfig(config);
Review comment:
> @BenJFan Because config will be used by plugin
Any problem with `plugin.setConfig` outside of
`createPluginInstanceIgnoreCase` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
