ruanwenjun commented on a change in pull request #1523:
URL:
https://github.com/apache/incubator-seatunnel/pull/1523#discussion_r833411112
##########
File path:
seatunnel-core/seatunnel-core-base/src/main/java/org/apache/seatunnel/config/ConfigBuilder.java
##########
@@ -157,6 +158,7 @@ private boolean checkIsContainHive() {
String serviceClassName = serviceClass.getName();
String clsNameToLower = serviceClassName.toLowerCase();
if (clsNameToLower.equals(canonicalName.toLowerCase())) {
+ plugin.setConfig(config);
Review comment:
@asdf2014 I think it might be better to not set config in
`createPluginInstanceIgnoreCase` method. From the method name, we can easy to
know it just create a plugin instance, it doesn't reflect to do some other
initialize operation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
