ruanwenjun commented on code in PR #1911:
URL:
https://github.com/apache/incubator-seatunnel/pull/1911#discussion_r880124933
##########
seatunnel-connectors/seatunnel-connectors-flink/seatunnel-connector-flink-clickhouse/src/main/java/org/apache/seatunnel/flink/clickhouse/sink/client/ClickhouseClient.java:
##########
@@ -212,4 +221,12 @@ public ClickhouseTable getClickhouseTable(String database,
String table) {
}
+ public String localizationEngine(String engine, String ddl) {
Review Comment:
NIT: It's better to add UT for this method, and add comment what this method
does.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
