ruanwenjun commented on code in PR #1911:
URL:
https://github.com/apache/incubator-seatunnel/pull/1911#discussion_r881214077
##########
seatunnel-connectors/seatunnel-connectors-flink/seatunnel-connector-flink-clickhouse/src/main/java/org/apache/seatunnel/flink/clickhouse/sink/client/ClickhouseClient.java:
##########
@@ -212,4 +221,21 @@ public ClickhouseTable getClickhouseTable(String database,
String table) {
}
+ /**
+ * Localization the engine in clickhouse local table's createTableDDL to
support specific engine.
+ * For example: change ReplicatedMergeTree to MergeTree.
+ *
+ * @param engine original engine of clickhouse local table
+ * @param ddl createTableDDL of clickhouse local table
+ * @return createTableDDL of clickhouse local table which can support
specific engine
+ * TODO: support more engine
+ */
+ public static String localizationEngine(String engine, String ddl) {
Review Comment:
OK, I see your updated code, you remove the static, it's OK to me. In fact,
I perfer to change the public to default, this is not a problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
