ashulin commented on code in PR #2041:
URL:
https://github.com/apache/incubator-seatunnel/pull/2041#discussion_r914354678
##########
seatunnel-connectors/seatunnel-connectors-seatunnel/seatunnel-connector-seatunnel-common/src/main/java/org/apache/seatunnel/connectors/seatunnel/common/source/SingleSplitReaderContext.java:
##########
@@ -15,23 +15,23 @@
* limitations under the License.
*/
-package org.apache.seatunnel.connectors.seatunnel.fake.source;
+package org.apache.seatunnel.connectors.seatunnel.common.source;
-import org.apache.seatunnel.api.source.SourceSplit;
+import org.apache.seatunnel.api.source.Boundedness;
+import org.apache.seatunnel.api.source.SourceReader;
-public class FakeSourceSplit implements SourceSplit {
+public class SingleSplitReaderContext {
Review Comment:
Using composition prevents developers from using the
`SourceReader.Context#sendSplitRequest` and
`SourceReader.Context#sendSourceEventToCoordinator` methods. If we use
`implements`, we need to throw exceptions in this methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
