lhyundeadsoul commented on code in PR #2041:
URL:
https://github.com/apache/incubator-seatunnel/pull/2041#discussion_r914367824
##########
seatunnel-connectors/seatunnel-connectors-seatunnel/seatunnel-connector-seatunnel-common/src/main/java/org/apache/seatunnel/connectors/seatunnel/common/source/SingleSplitReaderContext.java:
##########
@@ -15,23 +15,23 @@
* limitations under the License.
*/
-package org.apache.seatunnel.connectors.seatunnel.fake.source;
+package org.apache.seatunnel.connectors.seatunnel.common.source;
-import org.apache.seatunnel.api.source.SourceSplit;
+import org.apache.seatunnel.api.source.Boundedness;
+import org.apache.seatunnel.api.source.SourceReader;
-public class FakeSourceSplit implements SourceSplit {
+public class SingleSplitReaderContext {
Review Comment:
It's a little unintelligible that `SingleSplitReaderContext` is **NOT** a
subclass of `SourceReader.Context` , How about following alternatives:
1. `SingleSplitReaderContext` implements `SourceReader.Context`, and remove
`sendSplitRequest ` `sendSourceEventToCoordinator ` from `SourceReader.Context`
if possible. I think these method may not belong Context Object.
2. Use implements, and throw exceptions. That also makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
