EricJoy2048 commented on code in PR #2913: URL: https://github.com/apache/incubator-seatunnel/pull/2913#discussion_r980977908
########## docs/en/connector-v2/sink/Assert.md: ########## @@ -21,7 +21,7 @@ A flink sink plugin which can assert illegal data by user defined rules |rules.field_value | ConfigList | no | - | |rules.field_value.rule_type | string | no | - | |rules.field_value.rule_value | double | no | - | - +| common-options | string | no | - | Review Comment: Type of `common-options` maybe not `string`, I think common-options have no type. ########## docs/en/connector-v2/sink/Assert.md: ########## @@ -52,6 +52,10 @@ The following rules are supported for now the value related to rule type +### common options [string] Review Comment: remove `[string]` ########## docs/en/connector-v2/source/Clickhouse.md: ########## @@ -26,14 +26,14 @@ Reading data from Clickhouse can also be done using JDBC ## Options -| name | type | required | default value | -|----------------|--------|----------|---------------| -| host | string | yes | - | -| database | string | yes | - | -| sql | string | yes | - | -| username | string | yes | - | -| password | string | yes | - | -| common-options | string | yes | - | +| name | type | required | default value | +| ----------------- | ------ | -------- | ------------- | +| host | string | yes | - | +| database | string | yes | - | +| sql | string | yes | - | +| username | string | yes | - | +| password | string | yes | - | +| result_table_name | string | no | - | Review Comment: replace `result_table_name` to `common-options` and this param have no type. ########## docs/en/connector-v2/sink/Console.md: ########## @@ -16,6 +16,12 @@ Used to send data to Console. Both support streaming and batch mode. | name | type | required | default value | | --- |--------|----------|---------------| +| common-options| string| no | - | + + +### common options [string] Review Comment: same as above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
