hailin0 commented on code in PR #2913: URL: https://github.com/apache/incubator-seatunnel/pull/2913#discussion_r981896487
########## docs/en/connector-v2/sink/Neo4j.md: ########## @@ -64,7 +65,9 @@ maximum transaction retry time(seconds). transaction fail if exceeded ### max_connection_timeout [long] The maximum amount of time to wait for a TCP connection to be established (seconds) +### common options [string] +Sink plugin common parameters, please refer to [Sink Common Options](common-options.md) for details Review Comment: add empty line after ########## docs/en/connector-v2/sink/HdfsFile.md: ########## @@ -122,6 +123,9 @@ Storage mode, currently supports `overwrite`. This means we will delete the old If `is_enable_transaction` is `true`, Basically, we won't encounter the same file name. Because we will add the transaction id to file name. For the specific meaning of each mode, see [save-modes](https://spark.apache.org/docs/latest/sql-programming-guide.html#save-modes) +### common options [string] Review Comment: add empty line before ########## docs/en/connector-v2/source/FakeSource.md: ########## @@ -23,6 +23,7 @@ just for testing, such as type conversion and feature testing | result_table_name | string | yes | - | | schema | config | yes | - | | row.num | long | no | 10 | +| result_table_name | string | no | - | Review Comment: as above ########## docs/en/connector-v2/sink/Enterprise-WeChat.md: ########## @@ -37,6 +38,9 @@ A list of userids to remind the specified members in the group (@ a member), @ a ### mentioned_mobile_list [array] Mobile phone number list, remind the group member corresponding to the mobile phone number (@ a member), @ all means remind everyone +### common options [string] Review Comment: add empty line before -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
