ashulin commented on code in PR #2980:
URL:
https://github.com/apache/incubator-seatunnel/pull/2980#discussion_r985649601
##########
seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/sink/writer/AbstractWriteStrategy.java:
##########
@@ -237,7 +236,7 @@ public void beginTransaction(Long checkpointId) {
*/
public List<String> getTransactionIdFromStates(List<FileSinkState>
fileStates) {
String[] pathSegments = new String[]{textFileSinkConfig.getPath(),
Constant.SEATUNNEL, jobId};
- String jobDir = String.join(File.separator, pathSegments) + "/";
+ String jobDir = String.join("/", pathSegments) + "/";
Review Comment:
You can replace the `/` of the `path` sink option with `File.separator`
##########
seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/sink/writer/AbstractWriteStrategy.java:
##########
@@ -237,7 +236,7 @@ public void beginTransaction(Long checkpointId) {
*/
public List<String> getTransactionIdFromStates(List<FileSinkState>
fileStates) {
String[] pathSegments = new String[]{textFileSinkConfig.getPath(),
Constant.SEATUNNEL, jobId};
- String jobDir = String.join(File.separator, pathSegments) + "/";
+ String jobDir = String.join("/", pathSegments) + "/";
Review Comment:
You can replace the `/` of the `path` sink option with `File.separator`.
Perhaps this is a more general solution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
