[GitHub] [incubator-seatunnel] ashulin commented on a diff in pull request #2980: [Bug][Connector-V2] Fix the bug of incorrect path in windows environment

Wed, 05 Oct 2022 13:16:17 -0700 


ashulin commented on code in PR #2980:
URL: 
https://github.com/apache/incubator-seatunnel/pull/2980#discussion_r985720335


##########
seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/sink/writer/AbstractWriteStrategy.java:
##########
@@ -237,7 +236,7 @@ public void beginTransaction(Long checkpointId) {
      */
     public List<String> getTransactionIdFromStates(List<FileSinkState> 
fileStates) {
         String[] pathSegments = new String[]{textFileSinkConfig.getPath(), 
Constant.SEATUNNEL, jobId};
-        String jobDir = String.join(File.separator, pathSegments) + "/";
+        String jobDir = String.join("/", pathSegments) + "/";

Review Comment:
   
![image](https://user-images.githubusercontent.com/36807946/193575255-cdcfd1e1-f8da-4a07-8871-8277d271cfd0.png)
   Please change FileSystemUtils#getFileSystem
   
   > FileSystem fileSystem = FileSystem.get(new File(path).toPath().toUri(), 
CONF);
   
   you can see 
https://stackoverflow.com/questions/51352404/how-can-i-get-a-proper-uri-in-java-windows



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to