TyrantLucifer commented on PR #3045:
URL: 
https://github.com/apache/incubator-seatunnel/pull/3045#issuecomment-1272814721

   > I have a different point of view, why don't we directly inherit 
SeaTunnelException to implement different types of Exception, but use 
enumeration to determine the Exception type? What is the use of Code for users? 
And it is impossible to manage all Exception through CommonErrorCode, and some 
Exceptions will use CommonErrorCode, and some will not be used.
   
   Every connector will implement their own codes. Unified exception make error 
message more clearly. If we directly inherit SeaTunnelException, for all 
modules    need create more and more exceptions. This is a good practice 
reference from datax.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to