TyrantLucifer commented on PR #3045:
URL: 
https://github.com/apache/incubator-seatunnel/pull/3045#issuecomment-1274013387

   > > I have a different point of view, why don't we directly inherit 
SeaTunnelException to implement different types of Exception, but use 
enumeration to determine the Exception type? What is the use of Code for users? 
And it is impossible to manage all Exception through CommonErrorCode, and some 
Exceptions will use CommonErrorCode, and some will not be used.
   > 
   > +1. It's better to use a different implementation.
   
   So if a connector has more than 10 types exceptions, do we need define more 
than 10 classes to display those? It's not a good option. More More 
fine-grained exception I want to show what should I do?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to