[GitHub] [incubator-seatunnel] Hisoka-X commented on a diff in pull request #3410: [Feature][Connector V2] expose configurable options in JDBC

Sun, 13 Nov 2022 18:15:13 -0800 


Hisoka-X commented on code in PR #3410:
URL: 
https://github.com/apache/incubator-seatunnel/pull/3410#discussion_r1021021082


##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/config/JdbcConfig.java:
##########
@@ -25,74 +27,74 @@
 
 public class JdbcConfig implements Serializable {
 
-    public static final String URL = "url";
+    public static final Option<String> URL = 
Options.key("url").stringType().noDefaultValue().withDescription("url");
 
-    public static final String DRIVER = "driver";
+    public static final Option<String> DRIVER =  
Options.key("driver").stringType().noDefaultValue().withDescription("driver");
 
-    public static final String CONNECTION_CHECK_TIMEOUT_SEC = 
"connection_check_timeout_sec";
+    public static final Option<Integer> CONNECTION_CHECK_TIMEOUT_SEC = 
Options.key("connection_check_timeout_sec").intType().noDefaultValue().withDescription("connection
 check time second");

Review Comment:
   In the doc, connection_check_timeout_sec have default value : 30
   
![image](https://user-images.githubusercontent.com/32387433/201561105-350f4260-dd4d-4dc1-848f-8206d168c7bb.png)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to