hailin0 commented on code in PR #3410:
URL:
https://github.com/apache/incubator-seatunnel/pull/3410#discussion_r1022243278
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/config/JdbcConfig.java:
##########
@@ -25,74 +27,76 @@
public class JdbcConfig implements Serializable {
- public static final String URL = "url";
+ private static final Integer DEFAULT_CONNECTION_CHECK_TIMEOUT_SEC = 30;
- public static final String DRIVER = "driver";
+ public static final Option<String> URL =
Options.key("url").stringType().noDefaultValue().withDescription("url");
- public static final String CONNECTION_CHECK_TIMEOUT_SEC =
"connection_check_timeout_sec";
+ public static final Option<String> DRIVER =
Options.key("driver").stringType().noDefaultValue().withDescription("driver");
- public static final String MAX_RETRIES = "max_retries";
+ public static final Option<Integer> CONNECTION_CHECK_TIMEOUT_SEC =
Options.key("connection_check_timeout_sec").intType().defaultValue(DEFAULT_CONNECTION_CHECK_TIMEOUT_SEC).withDescription("connection
check time second");
- public static final String USER = "user";
+ public static final Option<Integer> MAX_RETRIES =
Options.key("max_retries").intType().noDefaultValue().withDescription("max_retired");
- public static final String PASSWORD = "password";
+ public static final Option<String> USER =
Options.key("user").stringType().noDefaultValue().withDescription("user");
- public static final String QUERY = "query";
+ public static final Option<String> PASSWORD =
Options.key("password").stringType().noDefaultValue().withDescription("password");
- public static final String BATCH_SIZE = "batch_size";
+ public static final Option<String> QUERY =
Options.key("query").stringType().noDefaultValue().withDescription("query");
- public static final String BATCH_INTERVAL_MS = "batch_interval_ms";
+ public static final Option<Integer> BATCH_SIZE =
Options.key("batch_size").intType().noDefaultValue().withDescription("batch
size");
+ public static final Option<Integer> BATCH_INTERVAL_MS =
Options.key("batch_interval_ms").intType().noDefaultValue().withDescription("batch
interval milliSecond");
- public static final String IS_EXACTLY_ONCE = "is_exactly_once";
- public static final String XA_DATA_SOURCE_CLASS_NAME =
"xa_data_source_class_name";
+ public static final Option<String> IS_EXACTLY_ONCE =
Options.key("is_exactly_once").stringType().noDefaultValue().withDescription("exactly
once");
+ public static final Option<String> XA_DATA_SOURCE_CLASS_NAME =
Options.key("xa_data_source_class_name").stringType().noDefaultValue().withDescription("data
source class name");
- public static final String MAX_COMMIT_ATTEMPTS = "max_commit_attempts";
- public static final String TRANSACTION_TIMEOUT_SEC =
"transaction_timeout_sec";
+ public static final Option<String> MAX_COMMIT_ATTEMPTS =
Options.key("max_commit_attempts").stringType().noDefaultValue().withDescription("max
commit attempts");
+
+ public static final Option<String> TRANSACTION_TIMEOUT_SEC =
Options.key("transaction_timeout_sec").stringType().noDefaultValue().withDescription("transaction
timeout (second)");
//source config
- public static final String PARTITION_COLUMN = "partition_column";
- public static final String PARTITION_UPPER_BOUND = "partition_upper_bound";
- public static final String PARTITION_LOWER_BOUND = "partition_lower_bound";
- public static final String PARTITION_NUM = "partition_num";
+ public static final Option<String> PARTITION_COLUMN =
Options.key("partition_column").stringType().noDefaultValue().withDescription("partition
column");
+ public static final Option<String> PARTITION_UPPER_BOUND =
Options.key("partition_upper_bound").stringType().noDefaultValue().withDescription("partition
upper bound");
+ public static final Option<String> PARTITION_LOWER_BOUND =
Options.key("partition_lower_bound").stringType().noDefaultValue().withDescription("partition
lower bound");
+ public static final Option<String> PARTITION_NUM =
Options.key("partition_num").stringType().noDefaultValue().withDescription("partition
num");
Review Comment:
```suggestion
public static final Option<String> PARTITION_UPPER_BOUND =
Options.key("partition_upper_bound").longType().noDefaultValue().withDescription("partition
upper bound");
public static final Option<String> PARTITION_LOWER_BOUND =
Options.key("partition_lower_bound").longType().noDefaultValue().withDescription("partition
lower bound");
public static final Option<String> PARTITION_NUM =
Options.key("partition_num").intType().noDefaultValue().withDescription("partition
num");
```
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/options/JdbcConnectionOptions.java:
##########
@@ -24,7 +24,7 @@
implements Serializable {
private static final long serialVersionUID = 1L;
- private static final int DEFAULT_CONNECTION_CHECK_TIMEOUT_SEC = 30;
+ private static final int DEFAULT_CONNECTION_CHECK_TIMEOUT_SEC =
org.apache.seatunnel.connectors.seatunnel.jdbc.config.JdbcConfig.CONNECTION_CHECK_TIMEOUT_SEC.defaultValue();
Review Comment:
```suggestion
private static final int DEFAULT_CONNECTION_CHECK_TIMEOUT_SEC =
JdbcConfig.CONNECTION_CHECK_TIMEOUT_SEC.defaultValue();
```
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/options/JdbcConnectorOptions.java:
##########
@@ -28,7 +28,7 @@
implements Serializable {
private static final long serialVersionUID = 1L;
- private static final int DEFAULT_CONNECTION_CHECK_TIMEOUT_SEC = 30;
+ private static final int DEFAULT_CONNECTION_CHECK_TIMEOUT_SEC =
org.apache.seatunnel.connectors.seatunnel.jdbc.config.JdbcConfig.CONNECTION_CHECK_TIMEOUT_SEC.defaultValue();
Review Comment:
```suggestion
private static final int DEFAULT_CONNECTION_CHECK_TIMEOUT_SEC =
JdbcConfig.CONNECTION_CHECK_TIMEOUT_SEC.defaultValue();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
