Hisoka-X commented on code in PR #3576:
URL:
https://github.com/apache/incubator-seatunnel/pull/3576#discussion_r1032869751
##########
seatunnel-common/src/main/java/org/apache/seatunnel/common/config/Common.java:
##########
@@ -160,6 +163,15 @@ public static List<Path> getLibJars() {
}
}
+ /**
+ * return the jar package configured in env jars
+ */
+ public static Set<Path> getThirdPartyJars(String paths) {
+
+ return Arrays.stream(paths.split(";")).filter(s -> !"".equals(s))
+ .map(path ->
Paths.get(URI.create(path))).collect(Collectors.toSet());
Review Comment:
Suggestion: filter all path not end with `.jar`, and Log with warning.
##########
docs/en/connector-v2/EnvConf.md:
##########
@@ -0,0 +1,19 @@
+# EnvConf
+
+This document describes env configuration information,env unifies the
environment variables of all engines.
+
+## jars
+
+Third-party packages can be loaded via `jars`, like
`jars="file://local/jar1.jar;file://local/jar2.jar"`
+
+## job.mode
+
+You can configure whether the task is in batch mode or stream mode through
`job.mod`, like `job.mode = "BATCH"`
Review Comment:
```suggestion
You can configure whether the task is in batch mode or stream mode through
`job.mode`, like `job.mode = "BATCH"` or `job.mode = "STREAMING"`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
