EricJoy2048 commented on code in PR #3576:
URL:
https://github.com/apache/incubator-seatunnel/pull/3576#discussion_r1033471724
##########
seatunnel-engine/seatunnel-engine-client/src/main/java/org/apache/seatunnel/engine/client/job/JobExecutionEnvironment.java:
##########
@@ -76,6 +80,16 @@ public JobExecutionEnvironment(JobConfig jobConfig,
this.jobClient = new JobClient(seaTunnelHazelcastClient);
this.jobConfig.setJobContext(new JobContext(jobClient.getNewJobId()));
this.commonPluginJars.addAll(searchPluginJars());
+ this.commonPluginJars.addAll(new
ArrayList<>(Common.getThirdPartyJars(jobConfig.getEnvOptions()
+ .getOrDefault(EnvConstants.JARS,
"").toString()).stream().map(Path::toUri)
+ .map(uri -> {
+ try {
+ return uri.toURL();
+ } catch (MalformedURLException e) {
+ throw new RuntimeException("the uri of jar illegal:" +
uri, e);
Review Comment:
SeaTunnelEngineException?
##########
docs/en/connector-v2/EnvConf.md:
##########
@@ -0,0 +1,19 @@
+# EnvConf
+
+This document describes env configuration information,env unifies the
environment variables of all engines.
+
+## jars
+
+Third-party packages can be loaded via `jars`, like
`jars="file://local/jar1.jar;file://local/jar2.jar"`
+
+## job.mode
+
+You can configure whether the task is in batch mode or stream mode through
`job.mode`, like `job.mode = "BATCH"` or `job.mode = "STREAMING"`
+
+## execution.checkpoint.interval
Review Comment:
change to `checkpoint.interval` because
https://github.com/apache/incubator-seatunnel/pull/3353/files#diff-6f68c25dd21780017dc98d220278af32f5ced954e0a0cd4ef3f585fd3f85380e
##########
docs/en/connector-v2/EnvConf.md:
##########
@@ -0,0 +1,19 @@
+# EnvConf
+
+This document describes env configuration information,env unifies the
environment variables of all engines.
+
+## jars
+
+Third-party packages can be loaded via `jars`, like
`jars="file://local/jar1.jar;file://local/jar2.jar"`
+
+## job.mode
+
+You can configure whether the task is in batch mode or stream mode through
`job.mode`, like `job.mode = "BATCH"` or `job.mode = "STREAMING"`
+
+## execution.checkpoint.interval
+
+Gets the interval in which checkpoints are periodically scheduled.
+
+## execution.parallelism
Review Comment:
change to `parallelism` because
https://github.com/apache/incubator-seatunnel/pull/3353/files#diff-6f68c25dd21780017dc98d220278af32f5ced954e0a0cd4ef3f585fd3f85380e.
##########
docs/en/connector-v2/EnvConf.md:
##########
@@ -0,0 +1,19 @@
+# EnvConf
Review Comment:
Please add `job.name` to env document.
##########
docs/en/connector-v2/EnvConf.md:
##########
@@ -0,0 +1,19 @@
+# EnvConf
+
+This document describes env configuration information,env unifies the
environment variables of all engines.
+
+## jars
Review Comment:
Add `jars` to file
:https://github.com/apache/incubator-seatunnel/pull/3353/files#diff-6f68c25dd21780017dc98d220278af32f5ced954e0a0cd4ef3f585fd3f85380e
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
