MonsterChenzhuo commented on code in PR #3594:
URL:
https://github.com/apache/incubator-seatunnel/pull/3594#discussion_r1034283095
##########
seatunnel-connectors-v2/connector-http/connector-http-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/http/source/HttpSource.java:
##########
@@ -83,7 +88,7 @@ protected void buildSchemaWithConfig(Config pluginConfig) {
break;
default:
// TODO: use format SPI
- throw new UnsupportedOperationException("Unsupported
format: " + format);
+ throw new
HttpConnectorException(HttpConnectorErrorCode.FORMAT_FAILED, new
UnsupportedOperationException());
Review Comment:
ILLEGAL_ARGUMENT("COMMON-06", "Illegal argument") Illegal parameter
exception, will there be ambiguity in this place, misleading users
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]