[GitHub] [incubator-seatunnel] MonsterChenzhuo commented on a diff in pull request #3594: [Improve][Connector-V2][Http]Unified exception for http source & sink…

Mon, 28 Nov 2022 20:19:19 -0800 


MonsterChenzhuo commented on code in PR #3594:
URL: 
https://github.com/apache/incubator-seatunnel/pull/3594#discussion_r1034284036


##########
seatunnel-connectors-v2/connector-http/connector-http-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/http/source/HttpSource.java:
##########
@@ -83,7 +88,7 @@ protected void buildSchemaWithConfig(Config pluginConfig) {
                     break;
                 default:
                     // TODO: use format SPI
-                    throw new UnsupportedOperationException("Unsupported 
format: " + format);
+                    throw new 
HttpConnectorException(HttpConnectorErrorCode.FORMAT_FAILED, new 
UnsupportedOperationException());

Review Comment:
   <img width="1288" alt="图片" 
src="https://user-images.githubusercontent.com/60029759/204437682-808bad26-98ed-4c8d-9bbd-429cc8e9ebdb.png";>
   This place will probably support more types in the future
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to