TyrantLucifer commented on code in PR #3793:
URL: 
https://github.com/apache/incubator-seatunnel/pull/3793#discussion_r1058041984


##########
seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/sink/writer/TextWriteStrategy.java:
##########
@@ -79,7 +87,14 @@ public void write(@NonNull SeaTunnelRow seaTunnelRow) {
             } else {
                 fsDataOutputStream.write(rowDelimiter.getBytes());
             }
-            
fsDataOutputStream.write(serializationSchema.serialize(seaTunnelRow));
+            SeaTunnelRow seaTunnelRowNew = new 
SeaTunnelRow(sinkColumnsIndexInRow.size());

Review Comment:
   Here you can determine whether the number of SeaTunnelRow fields and the 
number of sinkColumnsIndexInRow are consistent, if consistent, can use the 
origin row not the new row. This will improve performance.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to