TyrantLucifer commented on code in PR #3793:
URL:
https://github.com/apache/incubator-seatunnel/pull/3793#discussion_r1058324442
##########
seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/sink/writer/TextWriteStrategy.java:
##########
@@ -79,7 +89,18 @@ public void write(@NonNull SeaTunnelRow seaTunnelRow) {
} else {
fsDataOutputStream.write(rowDelimiter.getBytes());
}
-
fsDataOutputStream.write(serializationSchema.serialize(seaTunnelRow));
+ if (seaTunnelRow.getFields().length !=
sinkColumnsIndexInRow.size()) {
Review Comment:
Project operation should implement in transform layer, sink layer should do
something more pure, IMO, if we add this logic in sink endpoint, we should
produce a new row to do this work, this will lower performance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
