TyrantLucifer commented on code in PR #3798: URL: https://github.com/apache/incubator-seatunnel/pull/3798#discussion_r1061453287
########## seatunnel-core/seatunnel-core-starter/src/main/java/org/apache/seatunnel/core/starter/utils/ConfigBuilder.java: ########## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.seatunnel.core.starter.utils; + +import org.apache.seatunnel.shade.com.typesafe.config.Config; +import org.apache.seatunnel.shade.com.typesafe.config.ConfigFactory; +import org.apache.seatunnel.shade.com.typesafe.config.ConfigRenderOptions; +import org.apache.seatunnel.shade.com.typesafe.config.ConfigResolveOptions; + +import lombok.NonNull; +import lombok.extern.slf4j.Slf4j; + +import java.nio.file.Path; +import java.nio.file.Paths; + +/** + * Used to build the {@link Config} from config file. + */ +@Slf4j +public class ConfigBuilder { + + private static final ConfigRenderOptions CONFIG_RENDER_OPTIONS = ConfigRenderOptions.concise().setFormatted(true); + + public ConfigBuilder() { + throw new UnsupportedOperationException("ConfigBuilder is a utility class and cannot be instantiated"); + } + + public static Config of(@NonNull String filePath) { + log.info("Loading config file from path: {}", filePath); + Config config = ConfigFactory + .parseFile(Paths.get(filePath).toFile()) + .resolve(ConfigResolveOptions.defaults().setAllowUnresolved(true)) + .resolveWith(ConfigFactory.systemProperties(), + ConfigResolveOptions.defaults().setAllowUnresolved(true)); + log.info("Parsed config file: {}", config.root().render(CONFIG_RENDER_OPTIONS)); + return config; + } Review Comment: Good idea. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
