TyrantLucifer commented on code in PR #3798:
URL:
https://github.com/apache/incubator-seatunnel/pull/3798#discussion_r1062072165
##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-iotdb-e2e/src/test/java/org/apache/seatunnel/e2e/connector/iotdb/IoTDBIT.java:
##########
@@ -95,7 +94,7 @@ public void startUp() throws Exception {
testDataset = generateTestDataSet();
}
- @TestTemplate
+ // temporary remote annotation while this pull request being merged
https://github.com/apache/incubator-seatunnel/pull/3798
Review Comment:
Done
##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-iotdb-e2e/src/test/java/org/apache/seatunnel/e2e/connector/iotdb/IoTDBIT.java:
##########
@@ -57,8 +56,8 @@
import java.util.stream.Stream;
@Slf4j
-@DisabledOnContainer(value = {}, type = {EngineType.SEATUNNEL,
EngineType.SPARK},
- disabledReason = "There is a conflict of thrift version between IoTDB and
Spark.Therefore.")
+@DisabledOnContainer(value = {}, type = {EngineType.SEATUNNEL,
EngineType.SPARK, EngineType.FLINK},
+ disabledReason = "There is a conflict of thrift version between IoTDB and
Spark.Therefore. Refactor starter module, so disabled in flink")
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
