lightzhao commented on code in PR #4118:
URL:
https://github.com/apache/incubator-seatunnel/pull/4118#discussion_r1105216135
##########
pom.xml:
##########
@@ -585,7 +585,15 @@
<promoteTransitiveDependencies>true</promoteTransitiveDependencies>
<artifactSet>
<excludes>
- <exclude>org.slf4j:*</exclude>
+ <!-- not excluded:
jcl-over-slf4j(commons-logging to slf4j bridge) -->
+ <exclude>org.slf4j:slf4j-api</exclude>
+ <exclude>org.slf4j:slf4j-jdk14</exclude>
+ <exclude>org.slf4j:slf4j-jcl</exclude>
+ <exclude>org.slf4j:slf4j-nop</exclude>
+ <exclude>org.slf4j:slf4j-simple</exclude>
+ <exclude>org.slf4j:slf4j-reload4j</exclude>
+ <exclude>org.slf4j:slf4j-log4j12</exclude>
+ <exclude>org.slf4j:log4j-over-slf4j</exclude>
Review Comment:
Using your method to test whether the distribution will
exclude<jul-to-slf4j>, as shown in the screenshot below.
<img width="966" alt="image"
src="https://user-images.githubusercontent.com/40714172/218620371-0795324c-cf04-40c5-9e43-ec4789dd54ae.png";>
My method is effective, as shown in the screenshot below.
<img width="916" alt="image"
src="https://user-images.githubusercontent.com/40714172/218620475-9a4c23e7-c11b-4386-83b2-cf542b8f4795.png";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
![https://user-images.githubusercontent.com/40714172/218620371-0795324c-cf04-40c5-9e43-ec4789dd54ae.png"](https://user-images.githubusercontent.com/40714172/218620371-0795324c-cf04-40c5-9e43-ec4789dd54ae.png"){kind=link}
![https://user-images.githubusercontent.com/40714172/218620475-9a4c23e7-c11b-4386-83b2-cf542b8f4795.png"](https://user-images.githubusercontent.com/40714172/218620475-9a4c23e7-c11b-4386-83b2-cf542b8f4795.png"){kind=link}