hailin0 commented on code in PR #4118:
URL:
https://github.com/apache/incubator-seatunnel/pull/4118#discussion_r1106627920
##########
pom.xml:
##########
@@ -585,7 +585,15 @@
<promoteTransitiveDependencies>true</promoteTransitiveDependencies>
<artifactSet>
<excludes>
- <exclude>org.slf4j:*</exclude>
+ <!-- not excluded:
jcl-over-slf4j(commons-logging to slf4j bridge) -->
+ <exclude>org.slf4j:slf4j-api</exclude>
+ <exclude>org.slf4j:slf4j-jdk14</exclude>
+ <exclude>org.slf4j:slf4j-jcl</exclude>
+ <exclude>org.slf4j:slf4j-nop</exclude>
+ <exclude>org.slf4j:slf4j-simple</exclude>
+ <exclude>org.slf4j:slf4j-reload4j</exclude>
+ <exclude>org.slf4j:slf4j-log4j12</exclude>
+ <exclude>org.slf4j:log4j-over-slf4j</exclude>
Review Comment:
> 1. enable this dependency
> https://github.com/apache/incubator-seatunnel/blob/dev/pom.xml#L185
> 2. add dependency to this location
> https://github.com/apache/incubator-seatunnel/blob/dev/pom.xml#L487
>
> ```
> <dependency>
> <groupId>org.slf4j</groupId>
> <artifactId>jul-to-slf4j</artifactId>
> </dependency>
> ```
>
> 3. add pulsar connector e2e
>
https://github.com/apache/incubator-seatunnel/tree/dev/seatunnel-e2e/seatunnel-connector-v2-e2e
Here are my test results
```shell
./mvnw -T 1C clean package -pl
seatunnel-core/seatunnel-flink-starter/seatunnel-flink-13-starter -am
-Dmaven.test.skip=true -Pseatunnel
```
<img width="957" alt="image"
src="https://user-images.githubusercontent.com/14371345/218926205-67e73e8d-7ca5-45b7-8ba9-463968fb3e16.png";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
![https://user-images.githubusercontent.com/14371345/218926205-67e73e8d-7ca5-45b7-8ba9-463968fb3e16.png"](https://user-images.githubusercontent.com/14371345/218926205-67e73e8d-7ca5-45b7-8ba9-463968fb3e16.png"){kind=link}