kpretty opened a new pull request, #4233:
URL: https://github.com/apache/incubator-seatunnel/pull/4233

   ## Purpose of this pull request
   ### for timestamp type data this is wrong
   <img width="612" alt="时间解析源代码" 
src="https://user-images.githubusercontent.com/77819741/221504078-f4d5ba85-baa5-442f-9e90-da4b579f5d29.png";>
   The error message is as follows
   <img width="1185" alt="时间戳转换失败" 
src="https://user-images.githubusercontent.com/77819741/221504328-0f9254c3-f5a7-4efd-9890-e76bf94986e4.png";>
   Therefore, for the timestamp type, it should be parsed into LocalDateTime 
like this
   
   ```java
   LocalDateTime.ofInstant(Instant.ofEpochMilli(Long.parseLong(fieldValue)), 
ZoneId.systemDefault());
   ```
   
   ### string parse inappropriate
   It is inappropriate to directly call `toString()` for string type data, and 
the sink will receive redundant `"`
   <img width="1167" alt="处理 TextNode 不恰当" 
src="https://user-images.githubusercontent.com/77819741/221505061-10d88900-6252-40c6-a08a-87fa192939c5.png";>
   
   ### final
   The current pr has already dealt with the above problems, and the final 
effect is as follows
   <img width="1325" alt="正确处理" 
src="https://user-images.githubusercontent.com/77819741/221505203-f3a6fe4a-f4e6-48f3-b2e0-5c0af99377a7.png";>
   
   
   ## Check list
   
   * [x] Code changed are covered with tests, or it does not need tests for 
reason:
   * [ ] If any new Jar binary package adding in your PR, please add License 
Notice according
     [New License 
Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
   * [ ] If necessary, please update the documentation to describe the new 
feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
   * [ ] If you are contributing the connector code, please check that the 
following files are updated:
     1. Update change log that in connector document. For more details you can 
refer to 
[connector-v2](https://github.com/apache/incubator-seatunnel/tree/dev/docs/en/connector-v2)
     2. Update 
[plugin-mapping.properties](https://github.com/apache/incubator-seatunnel/blob/dev/plugin-mapping.properties)
 and add new connector information in it
     3. Update the pom file of 
[seatunnel-dist](https://github.com/apache/incubator-seatunnel/blob/dev/seatunnel-dist/pom.xml)
   * [ ] Update the 
[`release-note`](https://github.com/apache/incubator-seatunnel/blob/dev/release-note.md).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to