Hisoka-X commented on code in PR #4328:
URL:
https://github.com/apache/incubator-seatunnel/pull/4328#discussion_r1136468950
##########
seatunnel-connectors-v2/connector-clickhouse/src/main/java/org/apache/seatunnel/connectors/seatunnel/clickhouse/sink/client/ClickhouseSinkWriter.java:
##########
@@ -54,6 +59,13 @@
private final ShardRouter shardRouter;
private final transient ClickhouseProxy proxy;
private final Map<Shard, ClickhouseBatchStatement> statementMap;
+ private transient ScheduledExecutorService scheduler;
+ private transient ScheduledFuture<?> scheduledFuture;
+ private transient JdbcBatchStatementExecutor clickHouseStatement;
+ private transient ClickhouseBatchStatement statement;
+ private transient IntHolder sizeHolder;
+ // Whether pre-initialization is required
+ private transient boolean isOpen;
Review Comment:
This field is not necessary
##########
seatunnel-connectors-v2/connector-clickhouse/src/main/java/org/apache/seatunnel/connectors/seatunnel/clickhouse/sink/client/ClickhouseSinkWriter.java:
##########
@@ -75,16 +87,17 @@ public void write(SeaTunnelRow element) throws IOException {
.indexOf(this.option.getShardMetadata().getShardKey());
shardKey = element.getField(i);
}
- ClickhouseBatchStatement statement =
statementMap.get(shardRouter.getShard(shardKey));
- JdbcBatchStatementExecutor clickHouseStatement =
statement.getJdbcBatchStatementExecutor();
- IntHolder sizeHolder = statement.getIntHolder();
+ this.statement = statementMap.get(shardRouter.getShard(shardKey));
+ this.clickHouseStatement = statement.getJdbcBatchStatementExecutor();
+ this.sizeHolder = statement.getIntHolder();
// add into batch
- addIntoBatch(element, clickHouseStatement);
- sizeHolder.setValue(sizeHolder.getValue() + 1);
+ addIntoBatch(element, this.clickHouseStatement);
+ this.sizeHolder.setValue(this.sizeHolder.getValue() + 1);
+ tryOpen();
Review Comment:
Move it into constructer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
