zhilinli123 commented on code in PR #4328:
URL: 
https://github.com/apache/incubator-seatunnel/pull/4328#discussion_r1136491404


##########
seatunnel-connectors-v2/connector-clickhouse/src/main/java/org/apache/seatunnel/connectors/seatunnel/clickhouse/sink/client/ClickhouseSinkWriter.java:
##########
@@ -54,6 +59,13 @@
     private final ShardRouter shardRouter;
     private final transient ClickhouseProxy proxy;
     private final Map<Shard, ClickhouseBatchStatement> statementMap;
+    private transient ScheduledExecutorService scheduler;
+    private transient ScheduledFuture<?> scheduledFuture;
+    private transient JdbcBatchStatementExecutor clickHouseStatement;
+    private transient ClickhouseBatchStatement statement;
+    private transient IntHolder sizeHolder;
+    // Whether pre-initialization is required
+    private transient boolean isOpen;

Review Comment:
   Can the boss point out the number of rows
   



##########
seatunnel-connectors-v2/connector-clickhouse/src/main/java/org/apache/seatunnel/connectors/seatunnel/clickhouse/sink/client/ClickhouseSinkWriter.java:
##########
@@ -54,6 +59,13 @@
     private final ShardRouter shardRouter;
     private final transient ClickhouseProxy proxy;
     private final Map<Shard, ClickhouseBatchStatement> statementMap;
+    private transient ScheduledExecutorService scheduler;
+    private transient ScheduledFuture<?> scheduledFuture;
+    private transient JdbcBatchStatementExecutor clickHouseStatement;
+    private transient ClickhouseBatchStatement statement;
+    private transient IntHolder sizeHolder;
+    // Whether pre-initialization is required
+    private transient boolean isOpen;

Review Comment:
   This is a historical commentary Please check the latest
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to