laglangyue commented on code in PR #4111:
URL: 
https://github.com/apache/incubator-seatunnel/pull/4111#discussion_r1161184467


##########
seatunnel-common/src/main/java/org/apache/seatunnel/common/utils/JsonUtils.java:
##########
@@ -244,6 +244,15 @@ public static ObjectNode parseObject(String text) {
         }
     }
 
+    public static ObjectNode parseObject(byte[] content) {

Review Comment:
   you mean thart use new String(byte[]).
   we use parseObject() to convert ST-Row to JsonObject, Jackson can directly 
read the byte array.
   For big josn, read byte array directly is better.
   
   and new String() may cause additional performance loss in my opinion.
   
   so I the overload is necessary



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to