TyrantLucifer commented on code in PR #4111:
URL:
https://github.com/apache/incubator-seatunnel/pull/4111#discussion_r1162664310
##########
seatunnel-formats/seatunnel-format-json/src/main/java/org/apache/seatunnel/format/json/canal/CanalJsonDeserializationSchema.java:
##########
@@ -137,7 +141,7 @@ public void deserialize(byte[] message,
Collector<SeaTunnelRow> out) {
}
throw new SeaTunnelJsonFormatException(
CommonErrorCode.JSON_OPERATION_FAILED,
- format("Null data value \"%s\" Cannot send downstream",
new String(message)));
+ format("Null data value \"%s\" Cannot send downstream",
jsonNode.asText()));
Review Comment:
@MonsterChenzhuo PTAL
##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/configuration/util/OptionUtil.java:
##########
@@ -103,4 +106,19 @@ private static String formatUnderScoreCase(String camel) {
}
return underScore.toString();
}
+
+ public static <T> T get(
Review Comment:
cc @ashulin PTAL
##########
seatunnel-common/src/main/java/org/apache/seatunnel/common/utils/JsonUtils.java:
##########
@@ -244,6 +244,15 @@ public static ObjectNode parseObject(String text) {
}
}
+ public static ObjectNode parseObject(byte[] content) {
Review Comment:
It's does not make sense, you can try to change the logic of
parseObject(String json)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
