laglangyue commented on code in PR #4570:
URL:
https://github.com/apache/incubator-seatunnel/pull/4570#discussion_r1165764721
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/source/JdbcSourceFactory.java:
##########
@@ -155,11 +155,11 @@ static PartitionParameter createPartitionParameter(
max =
config.getPartitionUpperBound().isPresent()
? config.getPartitionUpperBound().get()
- : Long.parseLong(rs.getString(1));
+ : rs.getLong(1);
Review Comment:
I have test some empty table (c1 int , c2 bigint ,c3 tinyint)
if query is corretly, PartitionParameter#minValue will not throw NPE,
because the getLong() return long ,it has default value 0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
