laglangyue commented on code in PR #4570:
URL:
https://github.com/apache/incubator-seatunnel/pull/4570#discussion_r1166303611
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/source/JdbcSourceFactory.java:
##########
@@ -155,11 +155,11 @@ static PartitionParameter createPartitionParameter(
max =
config.getPartitionUpperBound().isPresent()
? config.getPartitionUpperBound().get()
- : Long.parseLong(rs.getString(1));
+ : rs.getLong(1);
Review Comment:
done, I refactor Long to long, it has default value if not set.
Besides, the property of PartitionParameter has no private added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
