ruanwenjun commented on code in PR #5598:
URL: https://github.com/apache/seatunnel/pull/5598#discussion_r1349662917
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/task/SinkAggregatedCommitterTask.java:
##########
@@ -262,7 +263,12 @@ public void restoreState(List<ActionSubtaskState>
actionStateList) throws Except
aggregatedCommitInfoSerializer.deserialize(
bytes)))
.collect(Collectors.toList());
- aggregatedCommitter.commit(aggregatedCommitInfos);
+ List<AggregatedCommitInfoT> commit =
+ aggregatedCommitter.restoreCommit(aggregatedCommitInfos);
+ if (CollectionUtils.isNotEmpty(commit)) {
+ log.error("aggregated committer error: {}", commit.size());
+ throw new
CheckpointException(CheckpointCloseReason.AGGREGATE_COMMIT_ERROR);
+ }
Review Comment:
We will commit/abort the commit info in restoreCommit, and this method will
return the commit info which the commit failed.
So when the commitInfo restore fails, then the job will fail. I am not sure
if this will cause the job cannot restart? If a commit info is timeout then it
cannot commit success.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
