Hisoka-X commented on code in PR #5598:
URL: https://github.com/apache/seatunnel/pull/5598#discussion_r1349664422
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/task/SinkAggregatedCommitterTask.java:
##########
@@ -262,7 +263,12 @@ public void restoreState(List<ActionSubtaskState>
actionStateList) throws Except
aggregatedCommitInfoSerializer.deserialize(
bytes)))
.collect(Collectors.toList());
- aggregatedCommitter.commit(aggregatedCommitInfos);
+ List<AggregatedCommitInfoT> commit =
+ aggregatedCommitter.restoreCommit(aggregatedCommitInfos);
+ if (CollectionUtils.isNotEmpty(commit)) {
+ log.error("aggregated committer error: {}", commit.size());
+ throw new
CheckpointException(CheckpointCloseReason.AGGREGATE_COMMIT_ERROR);
+ }
Review Comment:
This is acceptable, if commintInfo restore fail, means restore failed. If
you want restart your job, you can start without restore command.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
