Hisoka-X commented on code in PR #5645:
URL: https://github.com/apache/seatunnel/pull/5645#discussion_r1363040561
##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/table/catalog/CatalogTableUtil.java:
##########
@@ -66,47 +66,6 @@ public static CatalogTable getCatalogTable(String tableName,
SeaTunnelRowType ro
"It is converted from RowType and only has column
information.");
}
- // TODO remove this method after
https://github.com/apache/seatunnel/issues/5483 done.
- @Deprecated
- public static List<CatalogTable> getCatalogTables(Config config,
ClassLoader classLoader) {
Review Comment:
How about change `getCatalogTablesFromConfig` to `getCatalogTables` after
remove this method.
##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/table/catalog/CatalogTableUtil.java:
##########
@@ -66,47 +66,6 @@ public static CatalogTable getCatalogTable(String tableName,
SeaTunnelRowType ro
"It is converted from RowType and only has column
information.");
}
- // TODO remove this method after
https://github.com/apache/seatunnel/issues/5483 done.
- @Deprecated
- public static List<CatalogTable> getCatalogTables(Config config,
ClassLoader classLoader) {
Review Comment:
How about change `getCatalogTablesFromConfig` to `getCatalogTables` after
remove this method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
