Hisoka-X commented on code in PR #5645:
URL: https://github.com/apache/seatunnel/pull/5645#discussion_r1364811745
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/sink/JdbcSink.java:
##########
@@ -195,44 +191,37 @@ public DataSaveMode getUserConfigSaveMode() {
@Override
public void handleSaveMode(DataSaveMode saveMode) {
if (catalogTable != null) {
- Map<String, String> catalogOptions =
config.get(CatalogOptions.CATALOG_OPTIONS);
- if (catalogOptions != null) {
- String factoryId =
catalogOptions.get(CommonOptions.FACTORY_ID.key());
- if (StringUtils.isBlank(jdbcSinkConfig.getDatabase())) {
- return;
- }
- CatalogFactory catalogFactory =
- discoverFactory(
- Thread.currentThread().getContextClassLoader(),
- CatalogFactory.class,
- factoryId);
- if (catalogFactory != null) {
- try (Catalog catalog =
- catalogFactory.createCatalog(
- catalogFactory.factoryIdentifier(),
- ReadonlyConfig.fromMap(new
HashMap<>(catalogOptions)))) {
- catalog.open();
- FieldIdeEnum fieldIdeEnumEnum =
config.get(JdbcOptions.FIELD_IDE);
- String fieldIde =
- fieldIdeEnumEnum == null
- ? FieldIdeEnum.ORIGINAL.getValue()
- : fieldIdeEnumEnum.getValue();
- TablePath tablePath =
- TablePath.of(
- jdbcSinkConfig.getDatabase()
- + "."
- +
CatalogUtils.quoteTableIdentifier(
-
jdbcSinkConfig.getTable(), fieldIde));
- if
(!catalog.databaseExists(jdbcSinkConfig.getDatabase())) {
- catalog.createDatabase(tablePath, true);
- }
- catalogTable.getOptions().put("fieldIde", fieldIde);
- if (!catalog.tableExists(tablePath)) {
- catalog.createTable(tablePath, catalogTable, true);
- }
- } catch (Exception e) {
- throw new
JdbcConnectorException(HANDLE_SAVE_MODE_FAILED, e);
+ if (StringUtils.isBlank(jdbcSinkConfig.getDatabase())) {
+ return;
+ }
+ Optional<Catalog> catalogOptional =
+
JdbcCatalogUtils.findCatalog(jdbcSinkConfig.getJdbcConnectionConfig());
+ if (catalogOptional.isPresent()) {
+ try (Catalog catalog = catalogOptional.get()) {
+ catalog.open();
+ FieldIdeEnum fieldIdeEnumEnum =
config.get(JdbcOptions.FIELD_IDE);
+ String fieldIde =
+ fieldIdeEnumEnum == null
+ ? FieldIdeEnum.ORIGINAL.getValue()
+ : fieldIdeEnumEnum.getValue();
+ TablePath tablePath =
+ TablePath.of(
+ jdbcSinkConfig.getDatabase()
+ + "."
+ +
CatalogUtils.quoteTableIdentifier(
+ jdbcSinkConfig.getTable(),
fieldIde));
+ if (!catalog.databaseExists(jdbcSinkConfig.getDatabase()))
{
+ catalog.createDatabase(tablePath, true);
+ }
+ catalogTable.getOptions().put("fieldIde", fieldIde);
+ if (!catalog.tableExists(tablePath)) {
+ catalog.createTable(tablePath, catalogTable, true);
}
+ } catch (UnsupportedOperationException | CatalogException e) {
+ // TODO Temporary fix, this feature has been changed in
this pr
+ // https://github.com/apache/seatunnel/pull/5645
Review Comment:
Got it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
