Hisoka-X commented on code in PR #5542: URL: https://github.com/apache/seatunnel/pull/5542#discussion_r1372545680
########## docs/en/seatunnel-engine/optimize-job-submission.md: ########## @@ -0,0 +1,101 @@ +--- Review Comment: This doc more like design, not face to user. Please move it to the issue related to this PR. ########## docs/en/seatunnel-engine/optimize-job-submission.md: ########## @@ -0,0 +1,101 @@ +--- Review Comment: This doc more like design, not face to user. Please move it to issue related to this PR. ########## seatunnel-e2e/seatunnel-e2e-common/src/test/java/org/apache/seatunnel/e2e/common/container/seatunnel/ConnectorPackageServiceContainer.java: ########## @@ -0,0 +1,216 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.seatunnel.e2e.common.container.seatunnel; + +import org.apache.seatunnel.e2e.common.container.AbstractTestContainer; +import org.apache.seatunnel.e2e.common.container.ContainerExtendedFactory; +import org.apache.seatunnel.e2e.common.container.TestContainerId; +import org.apache.seatunnel.e2e.common.util.ContainerUtil; + +import org.testcontainers.containers.Container; +import org.testcontainers.containers.GenericContainer; +import org.testcontainers.containers.output.Slf4jLogConsumer; +import org.testcontainers.containers.wait.strategy.Wait; +import org.testcontainers.lifecycle.Startables; +import org.testcontainers.utility.DockerLoggerFactory; +import org.testcontainers.utility.MountableFile; + +import lombok.NoArgsConstructor; +import lombok.extern.slf4j.Slf4j; + +import java.io.IOException; +import java.nio.file.Paths; +import java.util.Arrays; +import java.util.Collections; +import java.util.List; +import java.util.stream.Stream; + +import static org.apache.seatunnel.e2e.common.util.ContainerUtil.PROJECT_ROOT_PATH; + +/** + * This class is the base class of SeatunnelEnvironment test for connector package service. The + * before method will create a Seatunnel Zeta cluster with connector package service enabled, and + * after method will close the Seatunnel Zeta cluster. You can use {@link + * ConnectorPackageServiceContainer#executeJob} to submit a seatunnel config and run a seatunnel + * job. + */ +@NoArgsConstructor +@Slf4j +public class ConnectorPackageServiceContainer extends AbstractTestContainer { Review Comment: Let us add `TestContainer` SPI to enable test on all exist test case. ```suggestion @AutoService(TestContainer.class) public class ConnectorPackageServiceContainer extends AbstractTestContainer { ``` ########## docs/en/seatunnel-engine/optimize-job-submission.md: ########## @@ -0,0 +1,101 @@ +--- Review Comment: This doc more like design, not face to user. Please move it to issue related to this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
