Hisoka-X commented on code in PR #5542:
URL: https://github.com/apache/seatunnel/pull/5542#discussion_r1372636746
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/task/TaskGroupImmutableInformation.java:
##########
@@ -40,6 +41,8 @@ public class TaskGroupImmutableInformation implements
IdentifiedDataSerializable
private Set<URL> jars;
+ private Set<ConnectorJarIdentifier> connectorJarIdentifiers;
Review Comment:
I think we should add some comment in code to tell other developers whats
difference between two jars collection. And what's reason why we should use two
jars collection. PS: I think we should just use `ConnectorJarIdentifier` for
all jars collection would be better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
