hailin0 commented on code in PR #5872:
URL: https://github.com/apache/seatunnel/pull/5872#discussion_r1404397822
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/dm/DamengCatalog.java:
##########
@@ -117,35 +113,24 @@ protected Column buildColumn(ResultSet resultSet) throws
SQLException {
String typeName = resultSet.getString("DATA_TYPE");
long columnLength = resultSet.getLong("DATA_LENGTH");
long columnPrecision = resultSet.getLong("DATA_PRECISION");
- long columnScale = resultSet.getLong("DATA_SCALE");
+ int columnScale = resultSet.getInt("DATA_SCALE");
String columnComment = resultSet.getString("COMMENTS");
Object defaultValue = resultSet.getObject("DATA_DEFAULT");
boolean isNullable = resultSet.getString("NULLABLE").equals("Y");
- SeaTunnelDataType<?> type =
- fromJdbcType(columnName, typeName, columnPrecision,
columnScale);
-
- return PhysicalColumn.of(
- columnName,
- type,
- 0,
- isNullable,
- defaultValue,
- columnComment,
- typeName,
- false,
- false,
- 0L,
- null,
- columnLength);
- }
-
- private SeaTunnelDataType<?> fromJdbcType(
- String columnName, String typeName, long precision, long scale) {
- Map<String, Object> dataTypeProperties = new HashMap<>();
- dataTypeProperties.put(DamengDataTypeConvertor.PRECISION, precision);
- dataTypeProperties.put(DamengDataTypeConvertor.SCALE, scale);
- return DATA_TYPE_CONVERTOR.toSeaTunnelType(columnName, typeName,
dataTypeProperties);
+ BasicTypeDefine typeDefine =
Review Comment:
```
LINEID COLUMN_NAME DATA_TYPE DATA_LENGTH DATA_PRECISION DATA_SCALE
NULLABLE DATA_DEFAULT COMMENTS
---------- ----------- --------- ----------- -------------- ----------
-------- ------------ --------
1 ID BIGINT 8 NULL 0 N
NULL NULL
2 F1 BIT 1 NULL 0 Y
NULL NULL
3 F2 TINYINT 1 NULL 0 Y
NULL NULL
4 F3 BYTE 1 NULL 0 Y
NULL NULL
5 F4 SMALLINT 2 NULL 0 Y
NULL NULL
6 F5 INT 4 NULL 0 Y
NULL NULL
7 F6 INTEGER 4 NULL 0 Y
NULL NULL
8 F7 INTEGER 4 NULL 0 Y
NULL NULL
9 F8 BIGINT 8 NULL 0 Y
NULL NULL
10 F9 REAL 4 NULL 0 Y
NULL NULL
11 F10 FLOAT 8 NULL 0 Y
NULL NULL
LINEID COLUMN_NAME DATA_TYPE DATA_LENGTH DATA_PRECISION
DATA_SCALE NULLABLE DATA_DEFAULT COMMENTS
---------- ----------- ---------------- ----------- --------------
---------- -------- ------------ --------
12 F11 DOUBLE 8 NULL 0
Y NULL NULL
13 F12 DOUBLE PRECISION 8 NULL 0
Y NULL NULL
14 F13 NUMERIC 22 NULL NULL
Y NULL NULL
15 F14 NUMERIC 22 10 0
Y NULL NULL
16 F15 NUMERIC 22 10 2
Y NULL NULL
17 F16 NUMBER 22 NULL NULL
Y NULL NULL
18 F17 NUMBER 22 10 0
Y NULL NULL
19 F18 NUMBER 22 10 2
Y NULL NULL
20 F19 DECIMAL 22 NULL NULL
Y NULL NULL
21 F20 DECIMAL 22 10 0
Y NULL NULL
22 F21 DECIMAL 22 10 2
Y NULL NULL
LINEID COLUMN_NAME DATA_TYPE DATA_LENGTH DATA_PRECISION DATA_SCALE
NULLABLE DATA_DEFAULT COMMENTS
---------- ----------- --------- ----------- -------------- ----------
-------- ------------ --------
23 F22 DEC 22 NULL NULL Y
NULL NULL
24 F23 DEC 22 10 0 Y
NULL NULL
25 F24 DEC 22 10 2 Y
NULL NULL
26 F25 CHAR 1 NULL 0 Y
NULL NULL
27 F26 CHAR 10 NULL 0 Y
NULL NULL
28 F27 CHARACTER 1 NULL 0 Y
NULL NULL
29 F28 CHARACTER 10 NULL 0 Y
NULL NULL
30 F29 VARCHAR 8188 NULL 0 Y
NULL NULL
31 F30 VARCHAR 10 NULL 0 Y
NULL NULL
32 F31 VARCHAR2 8188 NULL 0 Y
NULL NULL
33 F32 VARCHAR2 10 NULL 0 Y
NULL NULL
LINEID COLUMN_NAME DATA_TYPE DATA_LENGTH DATA_PRECISION DATA_SCALE
NULLABLE DATA_DEFAULT COMMENTS
---------- ----------- ------------- ----------- -------------- ----------
-------- ------------ --------
34 F33 TEXT 2147483647 NULL 0 Y
NULL NULL
35 F34 CLOB 2147483647 NULL 0 Y
NULL NULL
36 F35 LONGVARCHAR 2147483647 NULL 0 Y
NULL NULL
37 F36 CLOB 2147483647 NULL 0 Y
NULL NULL
38 F37 BINARY 1 NULL 0 Y
NULL NULL
39 F38 BINARY 10 NULL 0 Y
NULL NULL
40 F39 VARBINARY 8188 NULL 0 Y
NULL NULL
41 F40 VARBINARY 10 NULL 0 Y
NULL NULL
42 F41 LONGVARBINARY 2147483647 NULL 0 Y
NULL NULL
43 F42 LONGVARBINARY 2147483647 NULL 0 Y
NULL NULL
44 F43 IMAGE 2147483647 NULL 0 Y
NULL NULL
LINEID COLUMN_NAME DATA_TYPE DATA_LENGTH DATA_PRECISION
DATA_SCALE NULLABLE DATA_DEFAULT COMMENTS
---------- ----------- ------------------- ----------- --------------
---------- -------- ------------ --------
45 F44 BLOB 2147483647 NULL 0
Y NULL NULL
46 F45 BFILE 512 NULL 6
Y NULL NULL
47 F46 DATE 3 NULL 0
Y NULL NULL
48 F47 TIME 5 NULL 0
Y NULL NULL
49 F48 TIME 5 NULL 3
Y NULL NULL
50 F49 TIME WITH TIME ZONE 7 NULL 0
Y NULL NULL
51 F50 TIME WITH TIME ZONE 7 NULL 3
Y NULL NULL
52 F51 TIME 5 NULL 0
Y NULL NULL
53 F52 TIME 5 NULL 3
Y NULL NULL
54 F53 TIMESTAMP 8 NULL 6
Y NULL NULL
55 F54 TIMESTAMP 8 NULL 3
Y NULL NULL
LINEID COLUMN_NAME DATA_TYPE DATA_LENGTH DATA_PRECISION
DATA_SCALE NULLABLE DATA_DEFAULT COMMENTS
---------- ----------- ----------------------- ----------- --------------
---------- -------- ------------ --------
56 F55 DATETIME WITH TIME ZONE 10 NULL 6
Y NULL NULL
57 F56 DATETIME WITH TIME ZONE 10 NULL 3
Y NULL NULL
58 F57 TIMESTAMP 8 NULL 6
Y NULL NULL
59 F58 TIMESTAMP 8 NULL 3
Y NULL NULL
60 F59 DATETIME 8 NULL 6
Y NULL NULL
61 F60 DATETIME 8 NULL 3
Y NULL NULL
62 F61 DATETIME WITH TIME ZONE 10 NULL 6
Y NULL NULL
63 F62 DATETIME WITH TIME ZONE 10 NULL 3
Y NULL NULL
64 F63 DATETIME 8 NULL 6
Y NULL NULL
65 F64 DATETIME 8 NULL 3
Y NULL NULL
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
